Re: [PATCH] Handle double slashes in make_relative_path()

On Samstag, 23. Januar 2010, Johannes Sixt wrote:

On Samstag, 23. Januar 2010, Junio C Hamano wrote:

quoted

What happens if you did this?

	git --git-dir=//git/repo/repo.git --work-tree=/git/repo

where "//git/repo" is on the "git server" and you are working in local
hierarchy "/git/repo"?

Ah, right, this would not do the right thing. (But I can't verify this
claim right now.)

I tested it, and it does the right thing. The reason is that before 
setup_work_tree() calls make_relative_path(), the --work-tree argument has 
been processed by make_absolute_path(), which adds the drive prefix.

As long as setup_work_tree() remains the only caller of make_relative_path(), 
we are safe.

-- Hannes