Thread (9 messages) flat view 9 messages, 2 authors, 2016-06-15

Re: [PATCH] git-gui: set GIT_DIR and GIT_WORK_TREE after setup

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:48:05

Giuseppe Bilotta [off-list ref] wrote:
Rather than juggling with the env var GIT_DIR around the invocation of
gitk, set it and GIT_WORK_TREE after finishing setup, ensuring that any
external tool works with the setup we're running with.

This also allows us to remove a couple of conditionals when running gitk
or git gui in a submodule, as we know that the variables are present and
have to be unset and reset before and after the invocation.

Signed-off-by: Giuseppe Bilotta <redacted>
---
 git-gui.sh |   43 ++++++++++++++++++++-----------------------
 1 files changed, 20 insertions(+), 23 deletions(-)
Thanks, applied.

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help