[PATCH 0/3] Fixes to mh/rebase-fixup
flat view
DORMANTno replies
From: Michael Haggerty <hidden>
Date: 2016-06-15 22:48:05
This patch series contains fixes to the mh/rebase-fixup patch series as suggested by reviewers on the mailing list. Since the mh/rebase-fixup patch series is already in "next", I have written these fixup patches against "next". I hope that is OK. The third patch removes the attempt to use one-shot export of variables in do_with_author(), as the "$@" command that it calls might be a shell function. This issue was discussed on the mailing list [1]. This change has the side effect that the GIT_AUTHOR_* variables remain exported after do_with_author() returns, but I don't think that this is a problem in the context of git-rebase--interactive.sh. However, additional review would be welcome here. [1] http://marc.info/?l=git&m=126345851831751&w=2 Michael Haggerty (3): rebase -i: Avoid non-portable "test X -a Y" rebase -i: Enclose sed command substitution in quotes rebase -i: Export GIT_AUTHOR_* variables explicitly git-rebase--interactive.sh | 6 ++---- t/lib-rebase.sh | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-)