Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] git-mv: Fix error with multiple sources.

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:48:05

"David Rydh" [off-list ref] writes:
 		if (!is_absolute_path(given_config_file) && prefix)
-			config_exclusive_filename = prefix_filename(prefix,
+			config_exclusive_filename = xstrdup(prefix_filename(prefix,
 								    strlen(prefix),
-								    argv[2]);
+									argv[2]));
Broken indentation on the last two lines.

Other than that, you use strdup without free-ing the result. Probably
not so serious, but it may be cleaner to actually call free, or to
explain why you don't (in commit message).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help