[PATCH 7/9] gitweb: cleanup error message produced by undefined $site_header
From: "John 'Warthog9' Hawley" <warthog9@eaglescrag.net>
Date: 2016-06-15 22:48:01
Subsystem:
the rest · Maintainer:
Linus Torvalds
If $site_header is not defined you get extraneous errors in the web logs: [Wed Jan 13 16:55:42 2010] [error] [client ::1] [Wed Jan 13 16:55:42 2010] gitweb.cgi: Use of uninitialized value $site_header in -f at /var/www/gitweb/gitweb.cgi line 3287., referer: http://git/gitweb.cgi for example. This ensures that the variable is defined before trying to use it. --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 07fdeb5..c4a177d 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl@@ -3277,7 +3277,7 @@ EOF print "</head>\n" . "<body>\n"; - if (-f $site_header) { + if ($site_header && -f $site_header) { insert_file($site_header); }
--
1.6.5.2