Re: [PATCH] grep: do not do external grep on skip-worktree entries

On Mon, Jan 11, 2010 at 20:29, Linus Torvalds
[off-list ref] wrote:

On Mon, 11 Jan 2010, Fredrik Kuivinen wrote:

quoted

Any ideas on how this can be explained?

Could it be a bad 'strstr()' implementation?

Try a complex pattern ("qwerty.*as" finds the same line), and see if that
too is slower than before. If that is faster than it used to be (with
--no-ext-grep, of course), then it's strstr() that is badly implemented.

Ah, yes, that's it. With the pattern "qwerty.*as" I get 2.5s with the
patch and 6s without.

Thanks.

- Fredrik