Re: [PATCH] git-p4: Fix empty submit template when editor fires up

On Sun, Jan 10, 2010 at 7:14 PM, Jonathan Nieder [off-list ref] wrote:

Jonathan Nieder wrote:

quoted

Kevin Leung wrote:

quoted

read_pipe() returns "\n". We need to remove it before passing it
to system().

Signed-off-by: Kevin Leung <redacted>

If I understand correctly, this is a cosmetic change:

... and of course I didn't the subject.  Sorry about that.  Thanks
for cleaning up my mess.

Acked-by: Jonathan Nieder <redacted>

quoted

What is the rationale for the rewritten system() line?  I would have
understood a change to

      os.spawnlp("sh", "-c", editor + " \"$@\"", fileName)

I am still curious about this, though it is not so important.

You are right, the system() line is not so important. I can revert
that line of change.

Kevin