Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] ls-files: fix overeager pathspec optimization

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:59

Possibly related (same subject, not in this thread)

Linus Torvalds [off-list ref] writes:
On Sat, 9 Jan 2010, Junio C Hamano wrote:
quoted
Having sent these patches, I am wondering if the simplest fix might be this
one-liner.
diff --git a/dir.c b/dir.c
index d0999ba..7fba335 100644
--- a/dir.c
+++ b/dir.c
@@ -788,3 +788,3 @@ int read_directory(struct dir_struct *dir, const char *path, int len, const char
 	simplify = create_simplify(pathspec);
-	read_directory_recursive(dir, path, len, 0, simplify);
+	read_directory_recursive(dir, "", 0, 0, simplify);
 	free_simplify(simplify);
That one-liner doesn't work at all for me.
...
IOW, it now ignores _everything_, because the dir and the path don't 
match.
Hmph, you are right.  The real series is not equivalent to the one-liner
at all.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help