Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] daemon: consider only address in kill_some_child()

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:59

Erik Faye-Lund [off-list ref] writes:
kill_some_child() compares the entire sockaddr_storage structure (with
the pad-bits zeroed out) when trying to find out if connections
originate from the same host.  However, sockaddr_storage contains the
port-number for the connection (which varies between connections), so
the comparison always fails.

Change the code so we only consider the host-address, by introducing the
addrcmp()-function that inspects the address family and compare as
appropriate.

Signed-off-by: Erik Faye-Lund <redacted>
---
Makes sense.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help