Thread (8 messages) flat view 8 messages, 5 authors, 2016-06-15

Re: edit Author/Date metadata as part of 'git commit' $EDITOR invocation?

From: Adam Megacz <hidden>
Date: 2016-06-15 22:47:59

Junio C Hamano [off-list ref] writes:
Nanako Shiraishi [off-list ref] writes:
quoted
Quoting Adam Megacz [off-list ref]
quoted
Perhaps a preference (off by default) demanding that they be set
explicitly when "git commit -m" is used?
quoted
Sverre pointed out why this won't work.
I agree; making it a preference will not help.

I propose instead that "git commit -e" cause the metadata headers to be
provided to $EDITOR.  People who care about the metadata can simply get
in the habit of always passing that option when invoking "git commit".
The approach may have been Ok 10 years ago, back when `whoami`@`hostname`,
at least on systems that were competently maintained, gave a reasonable
mail address for most people, but I don't think it is adequate anymore to
majority of people,
I agree.
So I don't think anybody minds if we refuse to work if we are going to end
up using a name that we didn't get from an explicit end user configuration
(i.e. GIT_*_EMAIL and GIT_*_NAME environment and user.* configuration
variables).
I support that as well, although I'd still like to be shown the data.  I
wear a few different hats (each with its own email address), and I don't
think I want to pick one of them as the default.

Thanks,

  - a
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help