Thread (8 messages) flat view 8 messages, 2 authors, 2016-06-15

Re: [PATCH 3/3] Add "ls", which is basically ls-files with user-friendly settings

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:47:59

On 1/8/10, Junio C Hamano [off-list ref] wrote:
Nguyễn Thái Ngọc Duy  [off-list ref] writes:

 > +
 > +     if (show_colums) {
 > +             const char *argv[] = { "column", NULL };
 > +
 > +             memset(&cp, 0, sizeof(cp));
 > +             cp.in = -1;
 > +             cp.out = dup(1);
 > +             cp.argv = argv;
 > +             start_command(&cp);
 > +             close(1);
 > +             dup2(cp.in, 1);
 > +             close(cp.in);
 > +     }


I think the code for columnar output used in producing "git help -a"
 output should be reusable (if not, should be made reusable and reused
 here).
I saw that and even exported term_columns() but was too lazy to make
pretty_print_string_list() something reusable. Will think of it again
when I see this command is worth pushing forward.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help