Re: [PATCH v2] Use warning function instead of fprintf(stderr, "Warning: ...").
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:57
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH v2] Use warning function instead of fprintf(stderr, "Warning: ..."). · Thiago Farina <hidden>
- 2016-06-15 · Re: [PATCH v2] Use warning function instead of fprintf(stderr, "Warning: ..."). · Nanako Shiraishi <hidden>
Nanako Shiraishi [off-list ref] writes:
Quoting Thiago Farina [off-list ref]quoted
Signed-off-by: Thiago Farina <redacted> --- Removed the LF from the end of the strings.Trying this patch makes t6030-bisect-porcelain.sh fail for me. Was this tested at all?
I noticed it as well; will squash this in.
diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
index def397c..c51865f 100755
--- a/t/t6030-bisect-porcelain.sh
+++ b/t/t6030-bisect-porcelain.sh@@ -423,7 +423,7 @@ test_expect_success 'skipped merge base when good and bad are siblings' ' grep "merge base must be tested" my_bisect_log.txt && grep $HASH4 my_bisect_log.txt && git bisect skip > my_bisect_log.txt 2>&1 && - grep "Warning" my_bisect_log.txt && + grep "warning" my_bisect_log.txt && grep $SIDE_HASH6 my_bisect_log.txt && git bisect reset '