Thread (5 messages) flat view 5 messages, 4 authors, 2016-06-15

Re: [PATCH] Wrap completions in `type git' conditional statement.

From: Nanako Shiraishi <hidden>
Date: 2016-06-15 22:47:57

Quoting Shawn O. Pearce [off-list ref]:
Nanako Shiraishi [off-list ref] wrote:
quoted
Junio, could you tell us what happened to this thread?

The patch avoids failing completion script when git is not there.
No discussion.
Actually, that's probably my fault.  I never sent an ack or nak,
or anything else really, on this thread.

Originally this was because the completion was trying to run git
as it loaded.  In 1.6.6 this is no longer true, the completion list
is generated lazily on demand during the first completion attempt.

With the lazy loading, I didn't see a reason to add this ugly block
around the entire script.

-- 
Shawn.
Thank you for your explanation.

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help