Re: [PATCH/RFC] ignore unknown color configuration

On Tue, Dec 15, 2009 at 05:29:18PM -0800, Junio C Hamano wrote:

quoted

 	if (!prefixcmp(k, "status.color.") || !prefixcmp(k, "color.status.")) {
 		int slot = parse_status_slot(k, 13);
+		if (slot < 0)
+			return -1;

Shouldn't this return 0, to say "we handled it (by ignoring), don't
worry", instead of saying "hey it's error" by returning -1?  That's what
is done on the "diff" side below...

Yes, thank you for catching it. It should definitely be "return 0" (as
the other two cases are). It was a simple think-o on my part.

-Peff