Re: am fails to apply patches for files with CRLF lineendings

On 2009.12.14 18:50:44 -0600, Brandon Casey wrote:

I think it is more correct to say that the line termination in an email is
ambiguous.  CRLF does not necessarily mean that the original had CRLF line
termination if RFC-2822 is followed explicitly.

Right. And checking, after sending a patch containing CRs with mutt, it
lost those CRs. Even the local copy saved directly by mutt, which didn't
leave my box, lacks the CRs. So it seems basically impossible to send
patches to CRLF files inline.

RFC-822 still allowed bare CRs/LFs :-/

So the commit didn't break with anything mails conforming to RFC-2822,
those won't work for files with CR being patch. But it still breaks the
the raw format-patch generated patches, so even attaching them to the
actual email as a workaround won't do.

That makes a "use the first line to decide whether or not to strip CRs"
approach look like a good idea. Real mails are broken anyway, and the
format-patch output has LF on the first line, so mailsplit wouldn't mess
it up... Unless git on windows produces CRLF format-patch output...

Björn