Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH] help.autocorrect: do not run a command if the command given is junk

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:47:54

Hi,

On Mon, 14 Dec 2009, Johannes Sixt wrote:
From: Johannes Sixt <redacted>

If a given command is not found, then help.c tries to guess which one the
user could have meant. If help.autocorrect is 0 or unset, then a list of
suggestions is given as long as the dissimilarity between the given command
and the candidates is not excessively high. But if help.autocorrect was
non-zero (i.e., a delay after which the command is run automatically), the
latter restriction on dissimilarity was not obeyed.

In my case, this happened:

 $ git ..daab02
 WARNING: You called a Git command named '..daab02', which does not exist.
 Continuing under the assumption that you meant 'read-tree'
 in 4.0 seconds automatically...

The similarity limit that this patch introduces is already used a few lines
later where the list of suggested commands is printed.

Signed-off-by: Johannes Sixt <redacted>
---
Obvious ACK from me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help