Re: [PATCH 2/6] GITWEB - Missmatching git w/ gitweb

Hi,

On Thu, 10 Dec 2009, John 'Warthog9' Hawley wrote:

This adds $missmatch_git so that gitweb can run with a miss-matched
git install.

I'm not a native English speaker and all, but I thought it was spelt 
'mismatch', i.e. with only one 's'.  Maybe even name it 
'allow_different_git_version' or 'no_strict_git_version'.

A few comments on the patch: the style of the if() statement disagrees 
with the other ones; please use the same style.

Also, as with 1/6, turning off the feature might be better done by setting 
it to undef.

Finally, would it not be nicer if the warning really was only a warning, 
i.e. that the script would try to continue after giving the users a pretty 
warning header?

Ciao,
Dscho