Re: [PATCH] Add commit.status, --status, and --no-status

On Tue, Dec 8, 2009 at 02:13, Junio C Hamano [off-list ref] wrote:

Jeff King [off-list ref] writes:

quoted

On Mon, Dec 07, 2009 at 05:45:27PM -0500, James P. Howard, II wrote:

quoted

This commit provides support for commit.status, --status, and
--no-status, which control whether or not the git status information
is included in the commit message template when using an editor to
prepare the commit message.  It does not affect the effects of a
user's commit.template settings.

Thanks, this looks very cleanly done. The only complaint I would make is
that it should probably include a simple test case.

Yes.  Also I am a _bit_ worried about the name "status", as the longer
term direction is to make "status" not "a preview of commit", may confuse
people who do read Release Notes.

Right now, this option does not affect how the commit message is prepared
in git tag.  If the option were extended to cover that case as well, what would
a sensible name for the option be, then?

James

-- 
James P. Howard, II, MPA MBCS
jh@jameshoward.us