Re: [PATCH resend 0/3] transport: catch non-fast-forwards

On Fri, 4 Dec 2009, Tay Ray Chuan wrote:

This patch series applies on top of 'next', and deals with alerting
the user to non-fast-forward pushes when using helpers (smart).

Previously, git silently exited. This situation involves the curl
helper and the smart protocol. The fast-forward push is only detected
when curl executes the rpc client (git-send-pack). Now, we detect it
before telling the helper to push.

The first patch refactors ref status logic out of builtin-send-pack.c.

The second patch lets git know of non-fast-forwards before actually
telling the helper to push anything.

The third patch changes the return code when ref status indicate an
error (determined by push_had_errors()), so that the caller of
transport_push() is alerted.

Seems to me like transport_push() ought to set this sort of status 
information before calling the push method, rather than requiring all of 
the implementations to remember to call the generic function, since 
there's not really anything else sane they can do, right?

(There's eventually going to be at least a third push implementation: 
export the data to a foreign system a la "git svn dcommit")

	-Daniel
*This .sig left intentionally blank*