Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [RFC/PATCH 2/2] status -s: obey color.status

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:46

Michael J Gruber [off-list ref] writes:
* Should I rename wt-status.c's color() into something more unique when
  I export it?
Is it an option to instead move short_unmerged(), short_status() and
friends to wt-status.c from builtin-commit.c?  It's been quite a while
since I worked on the code, so I don't recall why it needs such cross
references at low level between two files.
* Is there any policy regarding use of putchar/puts vs. printf?
J6t addressed it.  You have mixture of putchar(' ') and printf(" ") which
looks somewhat funny ;-)
* The way it is done now I "color" a space, otherwise one would need to
  break down the print statements even more. Since we always color the
  foreground only it is no problem, is it?
Some people do configure to use "reverse".  For example, I have:

    [diff.color]
            old = red reverse
            whitespace = blue reverse

    [status.color]
            updated = green
            changed = red
            untracked = blue reverse

The output should be consistent between long and short format (I do not
offhand recall what we do for the long format, though).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help