Re: [PATCH] send-email: automatic envelope sender
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:46
Felipe Contreras [off-list ref] writes:
quoted hunk
diff --git a/git-send-email.perl b/git-send-email.perl index 4f5da4e..da2e56e 100755 --- a/git-send-email.perl +++ b/git-send-email.perl@@ -862,7 +862,11 @@ X-Mailer: git-send-email $gitversion my @sendmail_parameters = ('-i', @recipients); my $raw_from = $sanitized_sender; - $raw_from = $envelope_sender if (defined $envelope_sender); + if (defined $envelope_sender) { + if (not $envelope_sender eq "auto") { + $raw_from = $envelope_sender; + } + }
Thanks.
I'd rewrite this to
if (defined $envelope_sender && $envelope_sender ne "auto") {
...
}
but otherwise the patch looks quite straightforward.
Tests?