Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH RESEND] Explicitly truncate bswap operand to uint32_t

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:45

Benjamin Kramer [off-list ref] writes:
There are some places in git where a long is passed to htonl/ntohl. llvm
doesn't support matching operands of different bitwidths intentionally.
This patch fixes the build with llvm-gcc (and clang) on x86_64.

Signed-off-by: Benjamin Kramer <redacted>
---
Any comments on this patch?
My vague recollection is that the response was "we do not mind it per-se,
unless it ends up in an ugly change; but we would prefer if you go fix
your compiler", but maybe I read it on lkml not here?

Also my vague recollection is that the kernel folks took that patch in the
end, so I think it is Ok for us to take this patch, too.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help