Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] log --format: document %w

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:45

Possibly related (same subject, not in this thread)

René Scharfe [off-list ref] writes:
I think utf8_width() is too generic for that; we shouldn't teach it terminal
control details.
I agree that the function whose purpose is to compute display width should
not be called utf8_width().

The outside caller of utf8_width() in diff.c uses it to truncate the
function name hint on the hunk header line at character boundary.  The
input shouldn't have color escapes _we_ add (it might contain such
sequences from the user data, though), so I agree that we shouldn't
contaminate this function with color escapes.
strbuf_add_wrapped_text(); ignoring display mode escape codes in there can be
justified with its purpose.
Surely, and thanks.  The patch looks good.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help