Re: [PATCH v3] gitk: add --no-replace-objects option

On vendredi 20 novembre 2009, Junio C Hamano wrote:

Christian Couder [off-list ref] writes:

quoted

This option simply sets the GIT_NO_REPLACE_OBJECTS environment
variable, and that is enough to make gitk ignore replace refs.

This is a much less interesting implementation detail than everything
else you should talk about the new feature you are adding; why is it the
first sentence of the message?

This patch was previously the second patch in a 2 patch series so the 
previous patch was already explaining some context. Perhaps I should have 
sent the first patch again with this one.

quoted

The GIT_NO_REPLACE_OBJECTS is set to "1" instead of "" as it is
safer on some platforms, thanks to Johannes Sixt and Michael J
Gruber.

And this is even less interesting.

quoted

Replace refs are useful to change some git objects after they
have started to be shared between different repositories. One
might want to ignore them to see the original state.

This is what the reader needs to see to understand why this patch is
worthy of consideration.  It is a minor offense that the paragraph does
not end with "... original state, and --no-replace-objects option can be
used from the command line to do so", but this could be excused if this
is made the first paragraph in the message, close to the subject.

Ok, I will send the full series again with these changes.

I wonder if this switch deserves run-time flippability, though...

The following patch in master added run-time flippability to many commands:

http://git.kernel.org/?p=git/git.git;a=commit;h=b0fa7ab51b29d34579d8f6bb4443dfbcb8278c7a

and Michael J Gruber wrote "we need a way to specify
--no-replace-objects for gitk" in this message:

http://article.gmane.org/gmane.comp.version-control.git/132576/

Best regards,
Christian.