[PATCH v4 0/9] Default pager and editor

Junio C Hamano wrote: 

* jn/editor-pager (2009-10-30) 8 commits
 - Provide a build time default-pager setting
 - Provide a build time default-editor setting
 - am -i, git-svn: use "git var GIT_PAGER"
 - add -i, send-email, svn, p4, etc: use "git var GIT_EDITOR"
 - Teach git var about GIT_PAGER
 - Teach git var about GIT_EDITOR
 - Do not use VISUAL editor on dumb terminals
 - Handle more shell metacharacters in editor names

Any comments?

Here’s a reroll.  The interdiff is very small:

diff --git a/ident.c b/ident.c
index 99f1c85..26409b2 100644
--- a/ident.c
+++ b/ident.c

@@ -205,7 +205,7 @@ const char *fmt_ident(const char *name, const char *email,
 		if ((warn_on_no_name || error_on_no_name) &&
 		    name == git_default_name && env_hint) {
 			fprintf(stderr, env_hint, au_env, co_env);
-			env_hint = NULL; /* warn only once, for "git var -l" */
+			env_hint = NULL; /* warn only once */
 		}
 		if (error_on_no_name)
 			die("empty ident %s <%s> not allowed", name, email);

and the corresponding hunk in patch 3 could be safely discarded.
Aside from that, patch 3 has been unsquashed from patch 4, since it is
an independent fix that might be worth ejecting; the Signed-off-by
lines on patches 2 and 4 have been fixed; and the commit message for
patch 4 has been expanded to explain more.

In short, nothing of substance has changed.  If you are reminded of
any thoughts on the series, please let me know.

I think it is fair to say every one of these patches except the first
was someone else’s idea.  Thanks, everyone.

Jonathan Nieder (8):
  Handle more shell metacharacters in editor names
  Do not use VISUAL editor on dumb terminals
  Suppress warnings from "git var -l"
  Teach git var about GIT_EDITOR
  Teach git var about GIT_PAGER
  add -i, send-email, svn, p4, etc: use "git var GIT_EDITOR"
  am -i, git-svn: use "git var GIT_PAGER"
  Provide a build time default-editor setting

Junio C Hamano (1):
  Provide a build time default-pager setting

 Documentation/config.txt         |    4 +--
 Documentation/git-commit.txt     |    2 +-
 Documentation/git-send-email.txt |    4 +-
 Documentation/git-var.txt        |   14 +++++++++++
 Makefile                         |   28 ++++++++++++++++++++++
 cache.h                          |    2 +
 contrib/fast-import/git-p4       |    5 +---
 editor.c                         |   32 ++++++++++++++++++-------
 git-add--interactive.perl        |    3 +-
 git-am.sh                        |    5 +++-
 git-send-email.perl              |    3 +-
 git-sh-setup.sh                  |   19 +++++----------
 git-svn.perl                     |   11 +++-----
 ident.c                          |    2 +-
 pager.c                          |   24 ++++++++++++++++---
 t/t7005-editor.sh                |   47 ++++++++++++++++++++++++++++---------
 t/t7501-commit.sh                |    8 +++---
 t/test-lib.sh                    |    8 +++---
 var.c                            |   26 ++++++++++++++++++++-
 19 files changed, 178 insertions(+), 69 deletions(-)