Re: [PATCH] Define $PERL_PATH in test-lib.sh
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:47:42
Philippe Bruhat (BooK) schrieb:
quoted hunk ↗ jump to hunk
diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh index 64f947d..dc710f8 100755 --- a/t/t9400-git-cvsserver-server.sh +++ b/t/t9400-git-cvsserver-server.sh@@ -20,7 +20,7 @@ then say 'skipping git-cvsserver tests, cvs not found' test_done fi -perl -e 'use DBI; use DBD::SQLite' >/dev/null 2>&1 || { +$PERL_PATH -e 'use DBI; use DBD::SQLite' >/dev/null 2>&1 || {
Shouldn't this be "$PERL_PATH", i.e., double-quoted? (Ditto in the other cases that you replaced.)
quoted hunk ↗ jump to hunk
diff --git a/t/test-lib.sh b/t/test-lib.sh index f2ca536..54dd4d5 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh@@ -730,6 +730,8 @@ esac test -z "$NO_PERL" && test_set_prereq PERL +test -z "$NO_PERL" && test -z "$PERL_PATH" && export PERL_PATH=/usr/bin/perl
Wouldn't ... && export PERL_PATH=perl be a safer fall-back? -- Hannes