Re: [PATCH v2 4/4] Add explicit Cygwin check to guard WIN32 header inclusion

Ramsay Jones [off-list ref] writes:

Ramsay Jones wrote:

quoted

diff --git a/git-compat-util.h b/git-compat-util.h

...

Arrgghhh.

Sorry, Junio, I meant to change this before sending it out. :(

I had intended to remove the added indentation (which I don't even remember
doing!), since it obscures the "real change", which simply consists of the
new expression in the #if preprocessor line.

I'll send a new version of this patch.

Thanks for a notice.

The only reason I queue patches to 'pu' is to give them (slightly) wider
exposure than merely being in the mailing list archive, and I do not
expect myself merging this series to 'next' before seeing Acks from
Windows stakeholders, as I do not build anything on that platform myself.

I saw a comment on substance not form of this patch from J6t, and I
suspect that it was a more important issue.  You can de-indent while
sending your updated patch to address that issue.

Thanks.