Re: [RFC PATCH 3/3] t5551-http-fetch: Work around broken Accept header in libcurl
From: Tarmigan <hidden>
Date: 2016-06-15 22:47:41
On Mon, Nov 9, 2009 at 10:10 AM, Shawn O. Pearce [off-list ref] wrote:
Unfortunately at least one version of libcurl has a bug causing it to include "Accept: */*" in the same POST request where we have already asked for "Accept: application/x-git-upload-pack-response". This is a bug in libcurl, not Git, or our test vector. The application has explicitly asked the server for a single content type, but libcurl has mistakenly also told the server the client application will accept */*, which is any content type. Based on the libcurl change log, this "Accept: */*" header bug may have been fixed in version 7.18.1 released March 30, 2008: http://curl.haxx.se/changes.html#7_18_1 Rather than require users to upgrade libcurl we change the test vector to trim this line out of the 2nd request. Reported-by: Tarmigan <redacted>
Tested-by: Tarmigan <redacted>
Signed-off-by: Shawn O. Pearce <redacted>