Re: [PATCH 1/4] MSVC: Fix an "unresolved symbol" linker error on cygwin

Johannes Sixt [off-list ref] writes:

Ramsay Jones schrieb:

quoted

Junio C Hamano wrote:

quoted

Shouldn't this be solved by teaching the Makefile about this new "Cygwin
but using MSVC as compiler toolchain" combination?

Yes. Err... see patch #3 :-P

A clarifiction: Junio talks about using the MSVC tools to build Cygwin
programs, that is, to merely substitute Cygwin's gcc by MSVC, but to still
link against cygwin's C runtime.

Actually I do not talk about that; at least I meant to.

When the "MSVC build" of git is made, then the MSVC compiler is used, and
this will always use Microsoft libraries in the resulting executables,
regardless of whether "make MSVC=1" was called from a "cygwin environment"
or from and "msys environment".

This series is about fixing "make MSVC=1" when it is run from a "cygwin
environment" by disentangling the MSVC and Cygwin configuration sections
in the Makefile.

Yup.

I think we all three are in agreement that "When on Cygwin we do this"
part of the Makefile should be adjusted.  Even though I lost track of the
exact text in "patch #3", I can tell from Ramsay's response that the
series is about that.