Thread (8 messages) flat view 8 messages, 4 authors, 2016-06-15

Re: Problem with "From:" line on "git format-patch" generated patches

From: Jeff King <hidden>
Date: 2016-06-15 22:47:39

On Tue, Nov 03, 2009 at 04:06:39PM -0200, André Goddard Rosa wrote:
I'm not using any specific tool for inputting the git-format-patch,
but instead I'm sending the files generated by it through gmail as an
inlined patch in the email body.

I like the convenience of format-patch for generating the patch files,
but in this case, formatting the header as rfc2047 is not necessary
and makes a funny/garbled output in my patch submission.

Do you have a suggestion for my workflow?
I don't think there's currently a way to turn off the rfc2047 from
within format-patch. You can generate a single patch with the same
format using:

  git log -1 -p --stat --summary \
    --pretty=tformat:'From: %an <%ae>%nDate: %aD%nSubject: [PATCH] %s%n%n%b'

but it won't do nice things like putting one patch in each file.

Probably it would make sense for format-patch to have an option to
indicate that you are going to inline these patches into a different
MUA. So drop the 'From' mbox header line, don't rfc2047 encode, and
maybe some other behaviors. I do the same thing (including inline in
mutt), but I just delete the unwanted lines manually, and fortunately my
name doesn't contain any non-ascii characters. ;)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help