Re: [PATCH] Update packfile transfer protocol documentation

"Shawn O. Pearce" [off-list ref] writes:

Junio C Hamano [off-list ref] wrote:

quoted

"Shawn O. Pearce" [off-list ref] writes:

quoted

I don't think we ever send an empty packet.  If we have no data to
send, why the hell did we create the packet header?

Oh, I do not disagree that it is pointless, but the example that followed
the part we are discussing also had "0004".  I think it is Ok to allow it.

If its pointless, why encourage it?  Why not discourage it with SHOULD NOT?

Oh, no, I didn't mean to _encourage_ it.

I just thought that it being pointless at the semantic level would already
be an enough discouragement for people who are intelligent enough.

As I said, this was not an objection to start with.

Sure, but can't packet_write just return early without write()
if format_packet returned 4 (aka vsnprintf returned 0)?

Ah, that's right.