Thread (4 messages) 4 messages, 3 authors, 2016-06-15

Re: [PATCH] commit: More generous accepting of RFC-2822 footer lines.

flat view

From: SZEDER Gábor <hidden>
Date: 2016-06-15 22:47:39

Possibly related (same subject, not in this thread)

Hi,
quoted
From: David Brown <redacted>

'git commit -s' will insert a blank line before the Signed-off-by
line at the end of the message, unless this last line is a
Signed-off-by line itself.  Common use has other trailing lines
at the ends of commit text, in the style of RFC2822 headers.

Be more generous in considering lines to be part of this footer.
If the last paragraph of the commit message reasonably resembles
RFC-2822 formatted lines, don't insert that blank line.
I think this patch was a bit too generous.  If I make a one-line
commit message with git commit -s -m which has a colon in it, e.g.
'subsystem: what I did', then this patch removes the empty line
between the subject and the SOB line.


Best,
Gábor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help