Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] commit -c/-C/--amend: acquire authorship and restamp time with --claim

From: Erick Mattos <hidden>
Date: 2016-06-15 22:47:39

2009/11/1 Junio C Hamano [off-list ref]:
Erick Mattos [off-list ref] writes:
quoted
quoted
   % git commit --claim --author='Erick Mattos <eric@mattos>' -C HEAD

Should you detect an error?  Does your code do so?  Do you have a test
that catches this error?
It works as intended.  Both together.
That does not make any sense.  If you are saying this is yours and it is
his at the same time, there can be no sane way to work "as intended", no?.
I am adding a new option not changing the option --author already in
git.  So it does work together.
quoted
quoted
quoted
+     git commit -c HEAD <<EOF
+     "Changed"
+     EOF &&
What editor is reading this "Changed"?
Nobody cares...  Just a text to change the file.
I actually care.  Who uses that Changed string, and where does it end up
with?  At the end of the log message?  At the beginning?  What "file"?
I didn't get it.  -c option does not accept -m option and starts an
editor to change the message.  The text "Changed is just a forced
message.  I can not use an editor in interactive mode in a script...
What I am losing here??
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help