Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] Update packfile transfer protocol documentation

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:47:39

Shawn O. Pearce schrieb:
Scott Chacon [off-list ref] wrote:
quoted
+Currently only 'host' is allowed in the extra information.  It's
No.  We should make this a MUST.  As in:

	Only host-parameter is allowed in the git-proto-request.
	Clients MUST NOT attempt to send additional parameters.

Sending another header can cause older git-daemons to lock up.
I think you are making a wrong case here: Older git-daemons that lock up 
are security holes because they allow DoS attacks, and any decent admin 
will want to upgrade to a fixed git-daemon anyway.

Fixed git-daemons can allow extra information in addition to 'host'. I 
know you argued otherwise when you submitted the fix to git-daemon, but I 
think you were wrong already back then.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help