Re: [RFC PATCH v4 03/26] pkt-line: Make packet_read_line easier to debug

Jeff King [off-list ref] writes:

On Thu, Oct 29, 2009 at 02:58:29PM -0700, Shawn O. Pearce wrote:

quoted

Junio C Hamano [off-list ref] wrote:

quoted

quoted

The NUL assignment isn't about safe_read(), its about making the
block of 4 bytes read a proper C-style string so we can safely pass
it down into the snprintf that is within die().

I knew and understood all of what you just said.  static linelen[] is not
about stack allocation.  It's about letting the compiler initialize it to
five NULs so that you do not have to assign NUL to its fifth place before
you die.  This removes one added line from your patch.

Thanks, I get it now.  Patch amended.

I am just a bystander, so maybe my opinion is not worth anything, but
personally I think you are obfuscating the code to save a single line.

Well, the comment was not a serious "you should do it this way" to begin
with.  An extra assignment in the error path is not a big deal.