Re: [PATCH] clone: detect extra arguments
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:47:38
Subsystem:
the rest · Maintainer:
Linus Torvalds
Jeff King wrote:
Should we maybe be showing the usage in this case?
Sounds reasonable. How about this patch on top? -- %< -- Subject: [PATCH] clone: print usage on wrong number of arguments git clone's short usage string is only 22 lines, so an error message plus usage string still fits comfortably on an 80x24 terminal. Signed-off-by: Jonathan Nieder <redacted> --- builtin-clone.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/builtin-clone.c b/builtin-clone.c
index 76ad581..736d9e1 100644
--- a/builtin-clone.c
+++ b/builtin-clone.c@@ -378,10 +378,12 @@ int cmd_clone(int argc, const char **argv, const char *prefix) builtin_clone_usage, 0); if (argc > 2) - die("Too many arguments."); + usage_msg_opt("Too many arguments.", + builtin_clone_usage, builtin_clone_options); if (argc == 0) - die("You must specify a repository to clone."); + usage_msg_opt("You must specify a repository to clone.", + builtin_clone_usage, builtin_clone_options); if (option_mirror) option_bare = 1;
--
1.6.5.2