Re: [PATCH 7/7] Factor ref updating out of fetch_with_import

Sverre Rabbelier [off-list ref] wrote:

On Thu, Oct 29, 2009 at 07:22, Shawn O. Pearce [off-list ref] wrote:

quoted

Please define a transport_update_refs wrapper function to implement
this method invocation on the transport instance. ?Callers should
not be reaching into the struct transport directly.

With pleasure, should the transport_update_refs wrapper simply 'return
1' without doing anything if transport->update_refs is not set?

If the function isn't defined, it should behave as though it were
defined and successfully completed.
 

quoted

I certainly have to wonder... if this is done in both fetch and
clone, why isn't it just part of fetch_refs?

Because clone does not use fetch_refs, or am I missing something?

Hmmph.  Weird.  Its been a while since I last looked at this code,
maybe I misunderstood it.
 
-- 
Shawn.