Re: [msysGit] [PATCH v4 7/8] mingw: enable OpenSSL

Erik Faye-Lund schrieb:

On Wed, Oct 21, 2009 at 2:15 PM, Johannes Sixt [off-list ref] wrote:

quoted

I seem to have ack'ed this one too early. After testing in my environment,
I get:

imap-send.o: In function `ssl_socket_perror':
D:\Src\mingw-git/imap-send.c:241: undefined reference to `ERR_get_error'
D:\Src\mingw-git/imap-send.c:241: undefined reference to `ERR_error_string'

I need this patch in addition, and perhaps something similar is also
needed with MSVC:

Ah, yes - thanks for that one. I traced it a bit, and I found that it
works for me without your patch because I'm using OpenSSL's sha1, so
$(LIB_4_CRYPTO) is already included. Your fix is of course correct.
I'll squash it in and resend.

Indeed, I observed the failure after I set BLK_SHA1=YesPlease. I did this
exactly because it removes the dependency on libcrypto.dll from git.exe.

-- Hannes