Re: [PATCH] blame: make sure that the last line ends in an LF
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:35
Johannes Schindelin [off-list ref] writes:
Hi, On Tue, 20 Oct 2009, Junio C Hamano wrote:quoted
Sverre Rabbelier [off-list ref] writes:quoted
quoted
Or am I worrying too much?No, I think your concerns are valid, we should go with (2) and DTRT. Does the updated patch address your concerns? If so I can send a new version.Assuming the internal blame algorithm correctly works with such an input, I'd be happier with an approach to allow users to tell the difference. The --porcelain output was designed to be extensible, and it might make sense to show the "this line is incomplete" as a separate bit, though.Sorry, you lost me. If, say, line 614 is the last line that does not end in a new line, if I ask for it to be blamed, I want to know who is responsible for the current form of line 614. Not whether the line ends in a new line or not.
Yeah, I know. I was primarily worried about making the output format into something Porcelains (that read from --porcelain format) cannot reconstruct the original text from. See Message-ID: [ref] for a revised suggestion.