Re: [PATCH] Use faster byte swapping when compiling with MSVC
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:35
Johannes Schindelin [off-list ref] writes:
quoted
Well, in fact I am one of the msysgit poeple, although I mostly worked on the installer until now. In general, I like my patches to be reviewed, but this one is rather uncritical, I guess. So it's up to you, Junio, I'm perfectly OK with waiting for an ACK.Apart from the fact that I do not have MSVC (and I don't want it, either), there is another strong reason why I think Sebastian does not need ACKs or SOBs on MSVC patches: he has plenty of experience as a maintainer of a rather big (commercial) software that has to compile on Windows, MacOSX and several Unix-type OSes (and it is known that Sebastian is a Windows guy). So I would trust Sebastian's patches (at least when it comes to MSVC) without even reviewing them.
I very appreciate a strong Ack in a specific area like this. I do skim msysgit list from time to time, and in retrospect I realize I _could_ have recognized Sebastian's name but somehow it didn't click. I guess I should apply both patches to 'master', then. Thanks.