Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: Extra checks for PERL_PATH and SHELL_PATH?

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:35

Possibly related (same subject, not in this thread)

Matt Kraai [off-list ref] writes:
The top-level Makefile currently contains
quoted
ifndef SHELL_PATH
	SHELL_PATH = /bin/sh
endif
ifndef PERL_PATH
	PERL_PATH = /usr/bin/perl
endif
The checks are only necessary if these variables need to be overridden
by environment variables, not just via the make command line.  Is this
the case?
It may not have been the original intention, but the above would mean that
some people may have learned to run "SHELL_PATH=/bin/ksh make" and
changing it would break things for them, no?

I do not think changing them is bad per-se, but we would need to add extra
warnings in the release note to explain this change, that's all.  This
would only affect people who build from the source (including distro
people) so it is not really a big deal.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help