Junio C Hamano wrote:
The existing calls to format_commit_message() often take DATE_NORMAL to
its "enum date_mode dmode" argument, and you replaced it with a pointer to
a struct. DATE_NORMAL happens to be "0" and the compiler does not catch
calls you forgot to convert in this patch.
Hmph, that's embarrassing. Apparently I was way too focused on
pretty_print_commit...
I can devise a test that would have detected this. Should I include
it in the reroll, or is that something we do not guard against?
--
Thomas Rast
trast@{inf,student}.ethz.ch