Re: [RFC PATCH v3 00/17] Return of smart HTTP

On Thursday 15 October 2009, Shawn O. Pearce wrote:

Nanako Shiraishi [off-list ref] wrote:

quoted

quoted

"Shawn O. Pearce" [off-list ref] writes:

quoted

This v3 series is a respin, and includes fixes to address
reviewer comments from v2.

Junio, you merged this series to your "pu" branch, but it breaks
"make test" (t9801). Shawn's "sp/smart-http" topic doesn't have
t9801 and passes all the tests.

Actually, pu contains v2 right now, not v3.

And pu doesn't always pass the tests... because of issues like this.

It looks like there might be a semantic clash between John Herland's
jh/cvs-helper branch and my sp/smart-http branch... but digging
around at the code I haven't quite identified what that might be.

Don't have time to look into this at the moment, but a cursory gdb
shows that the "git fetch" in test #4 in t9801 segfaults with the
following stacktrace:

#0  0x00007f8dd67e8a47 in fclose () from /lib/libc.so.6
#1  0x00000000004a05b5 in disconnect_helper (transport=<value optimized out>) at transport-helper.c:81
#2  0x000000000049de1e in transport_disconnect (transport=0x1955490) at transport.c:952
#3  0x0000000000423477 in cmd_fetch (argc=26566704, argv=0x0, prefix=<value optimized out>) at builtin-fetch.c:748
#4  0x0000000000404233 in handle_internal_command (argc=2, argv=0x7fffdf293d20) at git.c:251
#5  0x0000000000404426 in main (argc=2, argv=0x7fffdf293d20) at git.c:438

Don't know if this helps...


...Johan

-- 
Johan Herland, [off-list ref]
www.herland.net