Re: git hang with corrupted .pack
From: Nicolas Pitre <nico@fluxnic.net>
Date: 2016-06-15 22:47:33
On Wed, 14 Oct 2009, Shawn O. Pearce wrote:
quoted hunk ↗ jump to hunk
Junio, can you please squash this in?diff --git a/t/t5303-pack-corruption-resilience.sh b/t/t5303-pack-corruption-resilience.sh index 5132d41..5f6cd4f 100755 --- a/t/t5303-pack-corruption-resilience.sh +++ b/t/t5303-pack-corruption-resilience.sh@@ -275,4 +275,13 @@ test_expect_success \ git cat-file blob $blob_2 > /dev/null && git cat-file blob $blob_3 > /dev/null' +test_expect_success \ + 'corrupting header to have too small output buffer fails unpack' \ + 'create_new_pack && + git prune-packed && + printf "\262\001" | do_corrupt_object $blob_1 0 && + test_must_fail git cat-file blob $blob_1 > /dev/null && + test_must_fail git cat-file blob $blob_2 > /dev/null && + test_must_fail git cat-file blob $blob_3 > /dev/null' + test_done--
I confirm this test without the fix reproduces the infinite loop (and does stall the test suite). Nicolas