Re: Git 1.6.5-rc git clone unhandled exception using http protocol

Michael Wookey [off-list ref] writes:

2009/10/13 Johannes Sixt [off-list ref]:

quoted

Michael Wookey schrieb:

quoted

Using the above repository, I see the same crash with msysGit at git
revision 1.6.5. Using windbg as the post-mortem debugger, the
following information is captured:
[ ... snip ... ]

Wow, this is great work, thank you very much! The function is
strip_path_suffix(). And here is a patch that fixes the crash.

--- >8 ---

From: Johannes Sixt <redacted>
Subject: [PATCH] remote-curl: add missing initialization of argv0_path

All programs, in particular also the stand-alone programs (non-builtins)
must call git_extract_argv0_path(argv[0]) in order to help builds that
derive the installation prefix at runtime, such as the MinGW build.
Without this call, the program segfaults (or raises an assertion
failure).

Signed-off-by: Johannes Sixt <redacted>
---
 remote-curl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/remote-curl.c b/remote-curl.c
index ad6a163..d8d276a 100644
--- a/remote-curl.c
+++ b/remote-curl.c

@@ -82,6 +82,7 @@ int main(int argc, const char **argv)

       const char *url;
       struct walker *walker = NULL;

+       git_extract_argv0_path(argv[0]);
       setup_git_directory();
       if (argc < 2) {
               fprintf(stderr, "Remote needed\n");
--
1.6.5.1024.g31034.dirty

No more crashes for me :)

Beautiful.  Thanks, both of you!