Re: [PATCH] Speedup bash completion loading

On Fri, Oct 09, 2009 at 07:46:06AM -0700, Shawn O. Pearce wrote:

Kirill Smelkov [off-list ref] wrote:

quoted

On Thu, Oct 08, 2009 at 08:02:06AM -0700, Shawn O. Pearce wrote:

quoted

We probably should place a quick comment here to remind folks that
they need to build the script in order to test it properly.

I've added some sort of protection, so that git-completion.bash.in can't
be sourced at all. Is it ok?

Yes, looks fine.

Thanks.

quoted

Subject: [PATCH 2/2] bash: make git-completion.bash.generate bash agnostic

Squash this into the first patch and add the egrep change made by
Stephen Boyd "[PATCH 1/2] completion: fix completion of git <TAB><TAB>".

While it is technically easy to do so, isn't this a bad idea to squash
semantic changes and fixes into something which should be as close as
code movement? Especially Stephen's fix?

Sure you are the maintainer, but maybe let's apply this 3 patches as
separate ones? I don't insist - this is just my 1коп.

Kirill