Re: [PATCH] MSVC: Enable OpenSSL, and translate -lcrypto

Erik Faye-Lund said the following on 03.10.2009 22:05:

On Sat, Oct 3, 2009 at 1:00 PM, Marius Storm-Olsen [off-list ref] wrote:

quoted

 This patch was actually sent using the MSVC
 git-imap-send.exe to my GMail account.
  D:\msvc\git>cat
0001-MSVC-Enable-OpenSSL-and-translate-lcrypto.patch |
git-imap-send.exe
  Resolving imap.gmail.com... ok
  Connecting to 74.125.79.109:993... ok
  Logging in...
  sending 1 message
  100% (1/1) done
 :)

Awesome :)

Yup, only sad to see that GMail dropped the In-reply-to when sending :-/

quoted

diff --git a/Makefile b/Makefile
index 8818f0f..c4b91d8 100644
--- a/Makefile
+++ b/Makefile

@@ -881,7 +881,6 @@ ifdef MSVC
       GIT_VERSION := $(GIT_VERSION).MSVC
       pathsep = ;
       NO_PREAD = YesPlease
-       NO_OPENSSL = YesPlease
       NO_LIBGEN_H = YesPlease
       NO_SYMLINK_HEAD = YesPlease
       NO_IPV6 = YesPlease

Didn't my 7/7 already do this hunk?

Not for MSVC. It has it's own section above the MinGW part. Besides, the
-lcrypto 'translation' is critical for it to link.

--
.marius