Re: [PATCH/RFC 5/7] imap-send: provide fall-back random-source
From: Erik Faye-Lund <hidden>
Date: 2016-06-15 22:47:28
On Sat, Oct 3, 2009 at 2:58 AM, Jeff King [off-list ref] wrote:
Hmm. It looks like this arc4 RNG is used just for generating a unique "X-TUID" header. Which seems to be used in isync (from which imap-send is derived) to be to avoid duplicates in synchronization. But imap-send doesn't actually use it for anything, as it just blindly pushes the messages. In other words, should all of this TUID code (and the arc4 code) simply be ripped out?
Possibly. I must admit that I didn't dig far on this one - I just added some randomness, and saw that things worked for me. I tried to trace this a little bit, but I got lost a bit in the callback-stuff. However, it looks to me like it might get sent to the server: it gets injected into cb.data in imap_store_msg(), and in v_issue_imap_cmd() it gets sent to the server if the LITERALPLUS capability is supported. I might be wrong though, as I find this code quite confusing. I CC'ed Mike McCormack, who initially added imap-send (including the arc4 code), as he *might* have more insight on this. It's a long-shot though, considering that this appears to be code adapted around 3.5 years ago. -- Erik "kusma" Faye-Lund kusmabite@gmail.com (+47) 986 59 656