Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer

Sebastian Schuberth [off-list ref] wrote:

On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce [off-list ref] wrote:

quoted

Something is wrong with both patches; neither applies. ??It looks
to be an issue with whitespace, like context lines are gaining an
extra space at the start of the line.

Hmm, the patches apply fine onto master for me.

After going through your client and the GMane email gateway?
Or before you pasted it into the message?
 

As a side note, I've never liked sending patches via mail. It just
feels like writing a text on a computer just to print it out, scan in
the sheet again, and then sending the scanned image as an attachment
via email. Isn't there a better way to contribute patches to Git, like
pushing to a mob branch as for the msysGit project?

It works fine, so long as the tools in the chain leave the body
of the message alone and don't try to outsmart the human who put
it there.

The git project in particular as rules about only applying patches
off the mailing list, because then all contributions are in a
permanent, public archive.  Its also the form of communication most
contributors prefer for code reviews.

-- 
Shawn.