Re: [PATCH] builtin-mailinfo.c: Trim only first pair of square brackets in subject
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:26
Neil Roberts [off-list ref] writes:
Roger Leigh [off-list ref] writes:quoted
Use a regular expression to match text after "Re:" or any text in the first pair of square brackets such as "[PATCH n/m]". This replaces the complex hairy string munging with a simple single pattern match.Is this patch going to get applied?
I do not think it is likely to happen for a patch without much comments
nor progress after this long blank period, without a refresher discussion.
It definitely won't be applied silently in its original form, especially
because the final comment in the old discussion on the patch in question
began with "One could _update_ ..." from the author of the patch, and then
nothing happened.
http://thread.gmane.org/gmane.comp.version-control.git/122418/focus=122466
I actually liked the much simpler one by Andreas in the original thread,
but if you really want to use a regexp (which we didn't have to) we should
make it configurable. See the neighbouring discussion here as well.
http://thread.gmane.org/gmane.comp.version-control.git/123322
I think we all agree that the behaviour should be improved, but I think
neither Roger's patch nor Andreas's one was the solution.. People who
care need to carry discussions and proposed patches forward to help us
agree on an acceptable solution.